Support for alias to inlined service #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When stacking decorators, all inlined services are prefixed by a
.. This character is explicitly removed in the service map since this commit.But then, when browsing aliases, the Xml factory is not able to find the target service in the map, because the alias definition contains the
., but not the stored service. The we got following false-positiveHow
I added the same log for
aliasfield that the one forid, and it fixed the issue locally. I added a test for this use case..has been removed in first place, maybe there are other (untested?) side-effects... at least the discussion is opened 🙂Thanks a lot for your work 🙇